Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove disallowed secret pattern match #12845

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jhockett
Copy link
Contributor

Description of changes

#11428 introduced a fake account id that is disallowed by our secret scanning. This PR switches the fake account id to an allowed value.

Issue #, if available

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner June 21, 2023 21:25
@codecov-commenter
Copy link

Codecov Report

Merging #12845 (d742239) into dev (ec9a2ba) will increase coverage by 48.42%.
The diff coverage is 61.68%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##              dev   #12845       +/-   ##
===========================================
+ Coverage    0.00%   48.42%   +48.42%     
===========================================
  Files        1296      835      -461     
  Lines      149743    37993   -111750     
  Branches     1296     7746     +6450     
===========================================
+ Hits            0    18398    +18398     
+ Misses     148447    18006   -130441     
- Partials     1296     1589      +293     
Impacted Files Coverage Δ
...ify-category-function/src/events/prePushHandler.ts 33.33% <0.00%> (+33.33%) ⬆️
...ider-utils/awscloudformation/utils/layerHelpers.ts 21.80% <0.00%> (+21.80%) ⬆️
...ib/S3AndCloudFront/helpers/configure-CloudFront.js 87.06% <ø> (+87.06%) ⬆️
...lify-category-hosting/lib/S3AndCloudFront/index.js 89.65% <ø> (+89.65%) ⬆️
...ifications/src/commands/notifications/configure.ts 0.00% <0.00%> (ø)
...e/src/amplify-node-pkg-detector/lock-file-types.ts 100.00% <ø> (+100.00%) ⬆️
.../src/amplify-node-pkg-detector/yarn-lock-parser.ts 100.00% <ø> (+100.00%) ⬆️
packages/amplify-cli-core/src/constants.ts 100.00% <ø> (+100.00%) ⬆️
...es/amplify-cli-core/src/context/plugin-platform.ts 33.33% <0.00%> (+33.33%) ⬆️
...s/amplify-cli-core/src/errors/amplify-exception.ts 82.35% <ø> (+82.35%) ⬆️
... and 37 more

... and 1257 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhockett jhockett merged commit 6e79818 into aws-amplify:dev Jun 21, 2023
@jhockett jhockett deleted the git-secret-fix branch June 21, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants